updated-packages

vendor/symfony/console/Helper/ProcessHelper.php

@@ -28,17 +28,20 @@ class ProcessHelper extends Helper
     /**
      * Runs an external process.
      *
-     * @param OutputInterface $output    An OutputInterface instance
-     * @param array|Process   $cmd       An instance of Process or an array of the command and arguments
-     * @param string|null     $error     An error message that must be displayed if something went wrong
-     * @param callable|null   $callback  A PHP callback to run whenever there is some
-     *                                   output available on STDOUT or STDERR
-     * @param int             $verbosity The threshold for verbosity
+     * @param array|Process $cmd       An instance of Process or an array of the command and arguments
+     * @param string|null   $error     An error message that must be displayed if something went wrong
+     * @param callable|null $callback  A PHP callback to run whenever there is some
+     *                                 output available on STDOUT or STDERR
+     * @param int           $verbosity The threshold for verbosity
      *
      * @return Process The process that ran
      */
     public function run(OutputInterface $output, $cmd, $error = null, callable $callback = null, $verbosity = OutputInterface::VERBOSITY_VERY_VERBOSE)
     {
+        if (!class_exists(Process::class)) {
+            throw new \LogicException('The ProcessHelper cannot be run as the Process component is not installed. Try running "compose require symfony/process".');
+        }
+
         if ($output instanceof ConsoleOutputInterface) {
             $output = $output->getErrorOutput();
         }
@@ -46,22 +49,22 @@ class ProcessHelper extends Helper
         $formatter = $this->getHelperSet()->get('debug_formatter');
 
         if ($cmd instanceof Process) {
-            $cmd = array($cmd);
+            $cmd = [$cmd];
         }
 
         if (!\is_array($cmd)) {
-            @trigger_error(sprintf('Passing a command as a string to "%s()" is deprecated since Symfony 4.2, pass it the command as an array of arguments instead.', __METHOD__), E_USER_DEPRECATED);
-            $cmd = array(\method_exists(Process::class, 'fromShellCommandline') ? Process::fromShellCommandline($cmd) : new Process($cmd));
+            @trigger_error(sprintf('Passing a command as a string to "%s()" is deprecated since Symfony 4.2, pass it the command as an array of arguments instead.', __METHOD__), \E_USER_DEPRECATED);
+            $cmd = [method_exists(Process::class, 'fromShellCommandline') ? Process::fromShellCommandline($cmd) : new Process($cmd)];
         }
 
         if (\is_string($cmd[0] ?? null)) {
             $process = new Process($cmd);
-            $cmd = array();
+            $cmd = [];
         } elseif (($cmd[0] ?? null) instanceof Process) {
             $process = $cmd[0];
             unset($cmd[0]);
         } else {
-            throw new \InvalidArgumentException(sprintf('Invalid command provided to "%s()": the command should an array whose first is element is either the path to the binary to run of a "Process" object.', __METHOD__));
+            throw new \InvalidArgumentException(sprintf('Invalid command provided to "%s()": the command should be an array whose first element is either the path to the binary to run or a "Process" object.', __METHOD__));
         }
 
         if ($verbosity <= $output->getVerbosity()) {
@@ -92,11 +95,10 @@ class ProcessHelper extends Helper
      * This is identical to run() except that an exception is thrown if the process
      * exits with a non-zero exit code.
      *
-     * @param OutputInterface $output   An OutputInterface instance
-     * @param string|Process  $cmd      An instance of Process or a command to run
-     * @param string|null     $error    An error message that must be displayed if something went wrong
-     * @param callable|null   $callback A PHP callback to run whenever there is some
-     *                                  output available on STDOUT or STDERR
+     * @param array|Process $cmd      An instance of Process or a command to run
+     * @param string|null   $error    An error message that must be displayed if something went wrong
+     * @param callable|null $callback A PHP callback to run whenever there is some
+     *                                output available on STDOUT or STDERR
      *
      * @return Process The process that ran
      *
@@ -118,10 +120,6 @@ class ProcessHelper extends Helper
     /**
      * Wraps a Process callback to add debugging output.
      *
-     * @param OutputInterface $output   An OutputInterface interface
-     * @param Process         $process  The Process
-     * @param callable|null   $callback A PHP callable
-     *
      * @return callable
      */
     public function wrapCallback(OutputInterface $output, Process $process, callable $callback = null)
@@ -136,12 +134,12 @@ class ProcessHelper extends Helper
             $output->write($formatter->progress(spl_object_hash($process), $this->escapeString($buffer), Process::ERR === $type));
 
             if (null !== $callback) {
-                \call_user_func($callback, $type, $buffer);
+                $callback($type, $buffer);
             }
         };
     }
 
-    private function escapeString($str)
+    private function escapeString(string $str): string
     {
         return str_replace('<', '\\<', $str);
     }