From 30c5a8ec2acd433c97d784bc80e5376f4bf6d21c Mon Sep 17 00:00:00 2001 From: Manish Verma Date: Fri, 4 Nov 2016 13:03:00 +0000 Subject: [PATCH] Applied fixes from StyleCI --- app/Http/Controllers/Admin/helpdesk/EmailsController.php | 4 ++-- app/Http/Controllers/Client/helpdesk/FormController.php | 6 ------ database/seeds/DatabaseSeeder.php | 4 ++-- 3 files changed, 4 insertions(+), 10 deletions(-) diff --git a/app/Http/Controllers/Admin/helpdesk/EmailsController.php b/app/Http/Controllers/Admin/helpdesk/EmailsController.php index ec9e14210..9aa4ef100 100644 --- a/app/Http/Controllers/Admin/helpdesk/EmailsController.php +++ b/app/Http/Controllers/Admin/helpdesk/EmailsController.php @@ -77,7 +77,7 @@ class EmailsController extends Controller // fetch all the helptopics from the helptopic table $helps = $help->get(); // fetch all the types of active priority from the ticket_priority table - $priority = $ticket_priority->where('status','=',1)->get(); + $priority = $ticket_priority->where('status', '=', 1)->get(); // fetch all the types of mailbox protocols from the mailbox_protocols table $mailbox_protocols = $mailbox_protocol->get(); @@ -320,7 +320,7 @@ class EmailsController extends Controller // get all the helptopic $helps = $help->get(); // get all active the priority - $priority = $ticket_priority->where('status','=',1)->get(); + $priority = $ticket_priority->where('status', '=', 1)->get(); // get all the mailbox protocols $mailbox_protocols = $mailbox_protocol->get(); diff --git a/app/Http/Controllers/Client/helpdesk/FormController.php b/app/Http/Controllers/Client/helpdesk/FormController.php index 3bbfa019e..98d29e3b0 100644 --- a/app/Http/Controllers/Client/helpdesk/FormController.php +++ b/app/Http/Controllers/Client/helpdesk/FormController.php @@ -93,10 +93,7 @@ class FormController extends Controller * @return type string */ public function postForm($id, Help_topic $topic) - - { - if ($id != 0) { $helptopic = $topic->where('id', '=', $id)->first(); $custom_form = $helptopic->custom_form; @@ -149,7 +146,6 @@ class FormController extends Controller */ public function postedForm(User $user, ClientRequest $request, Ticket $ticket_settings, Ticket_source $ticket_source, Ticket_attachments $ta, CountryCode $code) { - $form_extras = $request->except('Name', 'Phone', 'Email', 'Subject', 'Details', 'helptopic', '_wysihtml5_mode', '_token', 'mobile', 'Code'); $name = $request->input('Name'); $phone = $request->input('Phone'); @@ -186,10 +182,8 @@ class FormController extends Controller $user_priority = CommonSettings::where('id', '=', 6)->first(); if (!($request->input('priority'))) { $priority = $default_priority->priority_id; - } else { $priority = $request->input('priority'); - } $source = $ticket_source->where('name', '=', 'web')->first()->id; $attachments = $request->file('attachment'); diff --git a/database/seeds/DatabaseSeeder.php b/database/seeds/DatabaseSeeder.php index 3eecd9d3d..00f12934c 100644 --- a/database/seeds/DatabaseSeeder.php +++ b/database/seeds/DatabaseSeeder.php @@ -278,7 +278,7 @@ class DatabaseSeeder extends Seeder Company::create(['id' => '1']); Email::create(['id' => '1', 'template' => 'default', 'email_fetching' => '1', 'notification_cron' => '1', 'all_emails' => '1', 'email_collaborator' => '1', 'attachment' => '1']); Responder::create(['id' => '1', 'new_ticket' => '1', 'agent_new_ticket' => '1']); - System::create(array('id' => '1', 'status' => '1', 'department' => '1', 'date_time_format' => '1', 'time_zone' => '32')); + System::create(['id' => '1', 'status' => '1', 'department' => '1', 'date_time_format' => '1', 'time_zone' => '32']); Ticket::create(['num_format' => '$$$$-####-####', 'num_sequence' => 'sequence', 'collision_avoid' => '2', 'priority' => '1', 'sla' => '2', 'help_topic' => '1', 'status' => '1']); /* Ticket source */ Ticket_source::create(['name' => 'web', 'value' => 'Web']); @@ -2025,7 +2025,7 @@ class DatabaseSeeder extends Seeder /* * All the common settings will be listed here */ - CommonSettings::create([ 'option_name' => 'ticket_token_time_duration', 'option_value' => '1']); + CommonSettings::create(['option_name' => 'ticket_token_time_duration', 'option_value' => '1']); CommonSettings::create(['option_name' => 'enable_rtl', 'option_value' => '']); CommonSettings::create(['option_name' => 'user_set_ticket_status', 'status' => 1]); CommonSettings::create(['option_name' => 'send_otp', 'status' => 0]);