package and depencies

vendor/symfony/console/Helper/QuestionHelper.php

@@ -39,8 +39,8 @@ class QuestionHelper extends Helper
      */
     private $inputStream;
 
-    private static $stty = true;
-    private static $stdinIsInteractive;
+    private static bool $stty = true;
+    private static bool $stdinIsInteractive;
 
     /**
      * Asks a question to the user.
@@ -49,7 +49,7 @@ class QuestionHelper extends Helper
      *
      * @throws RuntimeException If there is no data to read in the input stream
      */
-    public function ask(InputInterface $input, OutputInterface $output, Question $question)
+    public function ask(InputInterface $input, OutputInterface $output, Question $question): mixed
     {
         if ($output instanceof ConsoleOutputInterface) {
             $output = $output->getErrorOutput();
@@ -84,10 +84,7 @@ class QuestionHelper extends Helper
         }
     }
 
-    /**
-     * {@inheritdoc}
-     */
-    public function getName()
+    public function getName(): string
     {
         return 'question';
     }
@@ -103,11 +100,9 @@ class QuestionHelper extends Helper
     /**
      * Asks the question to the user.
      *
-     * @return mixed
-     *
      * @throws RuntimeException In case the fallback is deactivated and the response cannot be hidden
      */
-    private function doAsk(OutputInterface $output, Question $question)
+    private function doAsk(OutputInterface $output, Question $question): mixed
     {
         $this->writePrompt($output, $question);
 
@@ -142,6 +137,7 @@ class QuestionHelper extends Helper
         }
 
         if ($output instanceof ConsoleSectionOutput) {
+            $output->addContent(''); // add EOL to the question
             $output->addContent($ret);
         }
 
@@ -154,10 +150,7 @@ class QuestionHelper extends Helper
         return $ret;
     }
 
-    /**
-     * @return mixed
-     */
-    private function getDefaultAnswer(Question $question)
+    private function getDefaultAnswer(Question $question): mixed
     {
         $default = $question->getDefault();
 
@@ -205,7 +198,7 @@ class QuestionHelper extends Helper
     /**
      * @return string[]
      */
-    protected function formatChoiceQuestionChoices(ChoiceQuestion $question, string $tag)
+    protected function formatChoiceQuestionChoices(ChoiceQuestion $question, string $tag): array
     {
         $messages = [];
 
@@ -411,7 +404,7 @@ class QuestionHelper extends Helper
             $exe = __DIR__.'/../Resources/bin/hiddeninput.exe';
 
             // handle code running from a phar
-            if ('phar:' === substr(__FILE__, 0, 5)) {
+            if (str_starts_with(__FILE__, 'phar:')) {
                 $tmpExe = sys_get_temp_dir().'/hiddeninput.exe';
                 copy($exe, $tmpExe);
                 $exe = $tmpExe;
@@ -437,6 +430,11 @@ class QuestionHelper extends Helper
 
         $value = fgets($inputStream, 4096);
 
+        if (4095 === \strlen($value)) {
+            $errOutput = $output instanceof ConsoleOutputInterface ? $output->getErrorOutput() : $output;
+            $errOutput->warning('The value was possibly truncated by your shell or terminal emulator');
+        }
+
         if (self::$stty && Terminal::hasSttyAvailable()) {
             shell_exec('stty '.$sttyMode);
         }
@@ -457,11 +455,9 @@ class QuestionHelper extends Helper
      *
      * @param callable $interviewer A callable that will ask for a question and return the result
      *
-     * @return mixed The validated response
-     *
      * @throws \Exception In case the max number of attempts has been reached and no valid response has been given
      */
-    private function validateAttempts(callable $interviewer, OutputInterface $output, Question $question)
+    private function validateAttempts(callable $interviewer, OutputInterface $output, Question $question): mixed
     {
         $error = null;
         $attempts = $question->getMaxAttempts();
@@ -488,7 +484,7 @@ class QuestionHelper extends Helper
             return false;
         }
 
-        if (null !== self::$stdinIsInteractive) {
+        if (isset(self::$stdinIsInteractive)) {
             return self::$stdinIsInteractive;
         }
 
@@ -514,10 +510,8 @@ class QuestionHelper extends Helper
      *
      * @param resource $inputStream The handler resource
      * @param Question $question    The question being asked
-     *
-     * @return string|false The input received, false in case input could not be read
      */
-    private function readInput($inputStream, Question $question)
+    private function readInput($inputStream, Question $question): string|false
     {
         if (!$question->isMultiline()) {
             $cp = $this->setIOCodepage();
@@ -543,11 +537,6 @@ class QuestionHelper extends Helper
         return $this->resetIOCodepage($cp, $ret);
     }
 
-    /**
-     * Sets console I/O to the host code page.
-     *
-     * @return int Previous code page in IBM/EBCDIC format
-     */
     private function setIOCodepage(): int
     {
         if (\function_exists('sapi_windows_cp_set')) {
@@ -562,12 +551,8 @@ class QuestionHelper extends Helper
 
     /**
      * Sets console I/O to the specified code page and converts the user input.
-     *
-     * @param string|false $input
-     *
-     * @return string|false
      */
-    private function resetIOCodepage(int $cp, $input)
+    private function resetIOCodepage(int $cp, string|false $input): string|false
     {
         if (0 !== $cp) {
             sapi_windows_cp_set($cp);